Repository navigation
objectstore-plugin: reload the exchange CA bundle on each handshake - #3839
Open
KR Ravindra (KR-Ravindra) wants to merge 1 commit into
Open
KR Ravindra (KR-Ravindra) wants to merge 1 commit into
KR Ravindra (KR-Ravindra) wants to merge 1 commit into
Conversation
The node-mode GCS plugin parsed the exchange CA bundle once into RootCAs, so a rotation of the servicedns CA broke token exchanges on every node until atelet was restarted. Verify the exchange's certificate in VerifyConnection against credbundle.PoolLoader, as the ate-api client already does. Signed-off-by: KR Ravindra <42912207+KR-Ravindra@users.noreply.github.com>
KR Ravindra (KR-Ravindra)
marked this pull request as ready for review
November 13, 2026 08:51
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The node-mode GCS plugin parses the exchange CA bundle once into
tls.Config.RootCAsinexchangeclient.New, so after the servicedns CA is rotated it keeps verifying the exchange against the old root. Token exchanges on nodes whose atelet predates the rotation fail withUnavailableand suspends crash the actor until atelet is restarted. The serving side already reloads per handshake.Fix
Verify the exchange's certificate in
VerifyConnectionagainstcredbundle.PoolLoader, asateapiauth.DialOptionsdoes, so a rotation applies on the next handshake. The startup load stays so a missing bundle still failsNew.How tested
New
TestNew_ReloadsTheCAFile: stub exchange with a cert from a second CA, exchange fails, bundle rewritten with both roots, next call on the same connection succeeds. Fails on main.Fixes #3256
AI use: AI-assisted, I reviewed and tested it. Experimented and verified with an AI agent.